Polar log scale: fix inner patch boundary and spine location #30223
+46
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
rcomer
changed the title
rcomer
commented
Jun 29, 2025
oscargus
approved these changes
Jun 29, 2025
timhoffm
approved these changes
Jun 30, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 30, 2025
…ry and spine location
oscargus
pushed a commit
that referenced
this pull request
Jun 30, 2025
…ne location (#30227) Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes #30179. The inner patch and spine positions are calculated in linear space, so we need to apply the scale's transform to min, max and origin.
The code from the OP now gives
The code from #30179 (comment) now gives
The test image looks like
I note there is an existing PR at #30185, but it appears to me unlikely to progress.
PR checklist