[MNT] Use Literal for level parameter in set_loglevel (#30257)
#30260
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please apply the same change to pyplot.set_loglevel |
jklymak
reviewed
Jul 4, 2025
| @@ -281,7 +283,9 @@ def _ensure_handler(): | |||
| return handler | |||
|
|
|||
|
|
|||
| def set_loglevel(level): | |||
| def set_loglevel( | |||
| level: Literal["notset", "debug", "info", "warning", "error", "critical"] | |||
There was a problem hiding this comment.
We don't have in-line types anywhere else in the code. I think this belongs in the pyi file. Note that this function is basically obsolete.
|
I think create a new TypeAlias in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the
strtype annotation withtyping.Literalfor thelevelparameter inmatplotlib.set_loglevel. This improves static type checking and IDE autocompletion for common log levels.Changes
Literaltype for accepted log level values:"notset","debug","info","warning","error","critical"Notes
Closes #30257