make SubplotTool into a modal dialog, keep ref to SubplotTool #9899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In using matplotlib (after PR #9356) on PyPy, I ran into an issue that the
TkAGG
SubplotTool
python object was being collected by the PyPy garbage collector (GC). It turns out that theSubplotTool
holds circular references, and these are resolved in the CPython GC much much later than in PyPy. I also noticed that theSubPlotTool
onTkAGG
is not a modal window, I can open many at the same time.PR Summary
This pull request solves both problems: holds a reference to the
SubplotTool
and makes the dialog into a modal dialog.Here is code that provides a basis for a manual test, I am not sure how to test the modality of a dialog box via a unittest:
PR Checklist