-
Notifications
You must be signed in to change notification settings - Fork 2.1k
chore: update error links from snake_case to kebab-case format #5544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: update error links from snake_case to kebab-case format #5544
Conversation
Hey @bpolaszek, Thank you for your contribution. Thanks again! |
Sure, consider it done 👍 |
Looks like error code slugs are generated somehow before running tests - I'll probably need a hand to figure this out 😕 |
@bpolaszek, you should revert all the files in meilisearch/crates/dump/src/reader/ that are not |
558aab6
to
05acc48
Compare
Hi @ManyTheFish, I applied your suggestions, but CI keeps failing. My knowledge of Rust unfortunately prevents me from going further. |
You need to run |
Additionally for errors like:
you will need to run |
…istency with updated documentation.
05acc48
to
43f22c6
Compare
@martin-g Done. |
@bpolaszek I see some unrelated failures now. Please rebase your branch to latest |
It is already ! https://github.com/bpolaszek/meilisearch/commits/fix/documentation-error-codes/ PS: Don't hesitate to |
All error links currently point to snake_cased anchors in the documentation, although anchors are actually kebab-cased on https://docs.meilisearch.com/errors.
i.e. invalid:
https://docs.meilisearch.com/errors#index_already_exists
valid:
https://docs.meilisearch.com/errors#index-already-exists
This PR just fixes the links so that you land on the appropriate error description in the documentation.
Sorry, that means editing tons of files, and involves a long & boring review 😅