ports/stm32: Enable FIFO for H7 controller. #16358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code size report: |
|
Side note: However, the As far as I can see, the current implementation for the G4 should run without FIFO despite this line. |
ennyKey
changed the title
ennyKey
changed the title
dpgeorge
approved these changes
Jun 26, 2025
The H7 has a hardware UART FIFO, so it's worth enabling it, to reduce the chance of missed incoming characters. Note that `HAL_UART_Init(&huart)` does not activate the FIFO, it must be done explicitly by calling `HAL_UARTEx_EnableFifoMode(&huart)`. Signed-off-by: ennyKey <ennyKey@fn.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my board I sometimes have the problem that single bytes get lost during UART communication at 115200 baud. I use the
UART.read()method and see that sometimes single bytes are missing in the middle of the data.The reason is that sometimes the receive interrupt of the UART is not called fast enough before the next byte is received.
Fortunately, the H7 controller has a hardware FIFO. This was not used in the existing implementation.
I enabled the FIFO in the code for the H7 controller and have never had a problem with missing bytes since.
As far as I know, using the FIFO has no negative effect on communication behaviour. Therefore, I do not think a configuration option is necessary at this point, and it can always be enabled.
I have tested the new implementation on a STM32H753 succesfully.