-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
stm32: fix a few bugs with ADC on STM32WBxx MCUs and tweak tests so they pass on NUCLEO_WB55 #17558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
See related Octoprobe issue: octoprobe/testbed_micropython#31 @hmaerki FYI |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17558 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 169 169
Lines 21968 21968
=======================================
Hits 21654 21654
Misses 314 314 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Code size report:
|
8b4102f
to
4d02d58
Compare
Octoprobe run results are here: https://reports.octoprobe.org/github_selfhosted_testrun_127/octoprobe_summary_report.html That looks a lot better, although still a few tests are failing. |
4d02d58
to
03134b4
Compare
@dpgeorge: Which usb connection do you use? I use the one behind 'RESET'.
What I am doing next:
|
It could be due to left over files on the filesystem, from the BT firmware update. Can you try to reset the filesystem with: import vfs, pyb
vfs.VfsFat.mkfs(pyb.Flash(start=0))
Those jumper settings are correct.
The one behind RESET is the correct USB port to use. |
5b2fcf8
to
893cadf
Compare
I have updated the tests here so that they should all now work on NUCLEO_WB55. If you bridge PA2/PA3 on the NUCLEO_WB55 (Arduino D0/D1 on CN9, or 35/37 on CN10) then that will allow the UART tests to pass. |
Stupid me. Thanks for your help! I didn't read the table in datasheet correctly. I will correct it tomorrow morning and run another test. |
Following 17898f8. Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
It needs a divisor of 100 because the calibration temperatures are 30 and 130 degrees, similar to the H5. Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
893cadf
to
4c2fb92
Compare
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
On stm32, the hardware generates an RXIDLE IRQ after enabling the UART, because the RX line is technically idle. Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
There should be no change to these tests for existing PYBV1x and PYBD_SFx boards. Signed-off-by: Damien George <damien@micropython.org>
1c56b6f
to
9d7e0b8
Compare
Eg on PYBV10 with THREAD variant, the firmware has both the `_thread` and `socket` modules but no NIC. Signed-off-by: Damien George <damien@micropython.org>
Summary
A NUCLEO_WB55 is part of the Octoprobe hardware test stack. This PR aims to get the test suite fully passing on this board.
The main thing here is to tweak the existing
tests/ports/stm32
tests, which were originally written for pyboards (PYBv1.x and PYBD-SFx). These tests should now pass on a wider variety of stm32 boards.Testing
Tested on a NUCLEO_WB55 via
./run-tests.py -t 0 -d ports/stm32
.CI and Octoprobe will also test this PR.