FEAT: adding tests for connection pooling speed and basic functionality #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds new tests for the connection pooling functionality in the mssql_python library, validating both performance improvements and pool size limits.
- Added test_connection_pooling_speed to compare connection times with/without pooling.
- Added test_connection_pooling_basic to confirm that the pool size limit is enforced and updated the import statement to include the pooling module.
bewithgaurav
previously approved these changes
Jun 27, 2025
jahnvi480
previously approved these changes
Jun 27, 2025
gargsaumya
force-pushed
the
saumya/mac-test
branch
from
650eb95 to
cde74c2
Compare
bewithgaurav
approved these changes
Jun 27, 2025
jahnvi480
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces new functionality to test connection pooling in the
mssql_pythonlibrary, along with some minor updates to imports in the test file. The most significant changes include adding tests for connection pooling speed and basic functionality, as well as updating the import statement to include thepoolingmodule.Connection pooling tests:
tests/test_003_connection.py: Addedtest_connection_pooling_speedto measure the performance improvement when using connection pooling compared to no pooling. Includes assertions to validate that pooled connections are faster.tests/test_003_connection.py: Addedtest_connection_pooling_basicto verify the functionality of connection pooling with a small pool size, ensuring connections are reused and respecting the pool size limit. Includes assertions and exception handling for edge cases.Import updates:
tests/test_003_connection.py: Updated import statement to include thepoolingmodule, which is required for the new connection pooling tests.