FEAT: Support Python < 3.13 on Unix #111
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds support for building macOS wheels for Python versions 3.12, 3.11, and 3.10 in the existing matrix configuration.
- Introduces
py312_universal2,py311_universal2, andpy310_universal2entries withpythonVersion,shortPyVer, andtargetArchset touniversal2. - Maintains consistency with the existing macOS universal2 strategy for Python 3.13.
- Leaves room for future version additions in the same pattern.
Comments suppressed due to low confidence (3)
eng/pipelines/build-whl-pipeline.yml:197
- [nitpick] This comment repeats the architecture information already noted above; consider simplifying it to just
# Python 3.12to reduce redundancy.
# Python 3.12 (universal2 for both arm64 and x86_64)
eng/pipelines/build-whl-pipeline.yml:197
- Don’t forget to update any external documentation or README files to list these newly supported Python versions so users are aware of 3.10, 3.11, and 3.12 support.
# Python 3.12 (universal2 for both arm64 and x86_64)
github-actions
bot
added
pr-size: small
github-actions
bot
added
pr-size: medium
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
github-actions
bot
added
pr-size: medium
| # Temporarily Use Azure SQL Database connection string for testing purposes since Docker takes too long to install & start in MacOS | ||
| DB_CONNECTION_STRING: $(AZURE_CONNECTION_STRING) | ||
| # DB_CONNECTION_STRING: 'Driver=ODBC Driver 18 for SQL Server;Server=localhost;Database=master;Uid=SA;Pwd=$(DB_PASSWORD);TrustServerCertificate=yes' | ||
| DB_CONNECTION_STRING: 'Driver=ODBC Driver 18 for SQL Server;Server=localhost;Database=master;Uid=SA;Pwd=$(DB_PASSWORD);TrustServerCertificate=yes' |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
github-actions
bot
added
pr-size: medium
bewithgaurav
changed the title
bewithgaurav
changed the title
bewithgaurav
changed the title
github-actions
bot
added
pr-size: medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO Work Item Reference
Summary
This pull request adds support for building Python wheels for additional Python versions in the
build-whl-pipeline.ymlfile. Specifically, configurations for Python 3.12, 3.11, and 3.10 with universal architecture (universal2) have been introduced.Pipeline updates:
eng/pipelines/build-whl-pipeline.yml: Added new job configurations for Python versions 3.12, 3.11, and 3.10, all targeting theuniversal2architecture for compatibility with botharm64andx86_64.