fix(server): validate expiresAt token value for non existence #446
+43
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochafik
requested changes
Jun 30, 2025
There was a problem hiding this comment.
Hi @christian-bromann, thanks for sending this out! Looks good, just a tiny nit in the test :-)
| it("should reject expired tokens", async () => { | ||
| it.each([ | ||
| [Math.floor(Date.now() / 1000) - 100], // Token expired 100 seconds ago | ||
| [0], // Token expires at the same time as now |
There was a problem hiding this comment.
This would place expiration at the Unix epoch / 1 January 1970. Maybe also test (unfloored) Date.now() / 1000 if you wanna check the boundary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
As mentioned in #173 the
expiresAtproperty of the token isn't validated quite correctly and doesn't distinguish between token not set and token being0.How Has This Been Tested?
I've added unit tests for this change.
Breaking Changes
no
Types of changes
Checklist
Additional context