Skip to content

Setting up pkg.pr.new #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

geelen
Copy link
Contributor

@geelen geelen commented May 30, 2025

This publishes NPM-compatible URLs for each commit on the repo:

image

image

This makes it possible for people (like myself!) to build against the SDK before it goes through a release, to validate that everything's working with the downstream packages.

It requires installing this GH app on the main repo: https://github.com/apps/pkg-pr-new

Tested this on the geelen fork (see screenshots) but this code really needs to be added as a branch to the main repo, then someone can iterate until they're happy with the output. Instructions for customisation are here, but I find the default look pretty much fine.

@geelen
Copy link
Contributor Author

geelen commented May 30, 2025

Currently failing with this as I don't have permissions to install it on this repo:

image

Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! Just wanted to clarify why we need this change to the release process:

  • we have a release process with versioning now, and scheduled releases every week on Thursday
  • running builds on every commit to every branch is wasteful - unless I misunderstand the config, sorry

@geelen
Copy link
Contributor Author

geelen commented Jul 1, 2025

The point is, for PRs like #717 (and #687 which introduced the bug), you can properly test that PR in projects that depend on the SDK.

For example, for https://github.com/modelcontextprotocol/use-mcp, the first I saw of the regression was when 1.13.2 was released. And then trying to track down which PR introduced it required linking the two projects together and wiring up the builds. Much easier to just click on the tick on each PR on github and try the SDK as it was at that point in time.

As for wastefulness, we already run builds on every commit/branch. This just saves the resulting package somewhere useful.

@ihrpr
Copy link
Contributor

ihrpr commented Jul 1, 2025

As for wastefulness, we already run builds on every commit/branch. This just saves the resulting package somewhere useful.
We do not build on every commit

I think more importantly, we do not auto-publish this SDK, we need an approval for publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants