Skip to content

Create a spam flag on automatic spam classificaiton #6706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Create a spam flag on automatic spam classificaiton #6706

merged 1 commit into from
Jun 10, 2025

Conversation

akatsoulas
Copy link
Collaborator

  • DRY up helpers

@akatsoulas akatsoulas mentioned this pull request Jun 5, 2025
Closed
escattone
escattone approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes.

kitsune/questions/utils.py
Comment on lines +236 to +243
flag_kwargs.update(
{
"notes": (
f"LLM classified as spam, for the following reason:\n"
f"{result.get('spam_result', {}).get('reason', '')}"
),
}
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. For me, the following is a bit simpler and more readable:

flag_kwargs.update(
    notes=(
        "LLM classified as spam, for the following reason:\n"
        f"{result.get('spam_result', {}).get('reason', '')}"
    )
)

@akatsoulas akatsoulas merged commit 899e78d into mozilla:main Jun 10, 2025
2 checks passed
@akatsoulas akatsoulas deleted the create-spam-flag-llm branch June 10, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escattone escattone escattone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akatsoulas @escattone