Locale switch from parent non-default locale document should 404 #6708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithellis
force-pushed
the
locale-switcher-non-default-language-doc
branch
from
0cb6240 to
6f52ab9
Compare
not in the default locale This covers a case where the user is on a document that is not in the default locale (in our case en-US) and is not a translation. If the user tries to use the locale switcher to go to English, since there is no parent as we are not on a translation, the user should get a 404.
smithellis
force-pushed
the
locale-switcher-non-default-language-doc
branch
from
6f52ab9 to
c54ccbd
Compare
escattone
approved these changes
Jun 6, 2025
| parent = get_object_or_404(Document.objects.visible(user, **kwargs)) | ||
| try: | ||
| parent = Document.objects.get_visible(user, **kwargs) | ||
| except Document.DoesNotExist: | ||
| raise Http404 | ||
|
|
There was a problem hiding this comment.
This change does the exact same thing as what it replaces, so I guess you're making the case that the change is more readable, and I can buy that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers a case where the user is on a document that is not in the default locale (in our case en-US) and is not a translation.
If the user tries to use the locale switcher to go to English, since there is no parent as we are not on a translation, the user should get a 404.