fix and simplify get_visible_document_or_404
#6710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escattone
commented
Jun 6, 2025
Comment on lines
-217
to
-219
| translation = parent.translated_to(locale, visible_for_user=user) | ||
| if translation: | ||
| return translation |
There was a problem hiding this comment.
I removed these lines because they're redundant. This case is already handled by the other_docs_qs-related code above.
escattone
force-pushed
the
locale-switcher-adjustments
branch
from
2a0d23b to
1511cf0
Compare
escattone
changed the title
get_visible_document_or_404get_visible_document_or_404
escattone
changed the title
get_visible_document_or_404get_visible_document_or_404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mozilla/sumo#2364
mozilla/sumo#2365
This PR also simplifies
get_visible_document_or_404().