Update SUMO logo and footer Mozilla logo #6734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the footer’s primary logo by embedding the SUMO wordmark as a background image and defining its dimensions and background styling.
- Adds an anchor wrapper for the primary logo in the footer.
- Sets the wordmark SVG as a background image and defines width, height, and background color.
Comments suppressed due to low confidence (2)
kitsune/sumo/static/sumo/scss/layout/_footer.scss:54
- Applying a white background behind a white wordmark may render the logo invisible; verify if this is intended or adjust to match the footer’s color scheme.
background-color: rgb(255, 255, 255);
kitsune/sumo/static/sumo/scss/layout/_footer.scss:52
- Using a background image on an anchor prevents screen readers from detecting the logo; consider using an
element with meaningful alt text for better accessibility.
a {
| @@ -49,6 +49,12 @@ | |||
|
|
|||
| &-primary-logo { | |||
| margin-bottom: p.$spacing-lg; | |||
| a { | |||
| background: url('sumo/img/wordmark-white.svg') no-repeat center; | |||
There was a problem hiding this comment.
Consider using a Sass variable or helper function for the image path to ensure consistency with your asset pipeline and simplify future updates.
Copilot uses AI. Check for mistakes.
akatsoulas
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.