Skip to content

only clear auto tags when updating question #6736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025

Conversation

escattone
Copy link
Contributor

@escattone escattone requested a review from akatsoulas June 24, 2025 23:38
Copy link
Collaborator

@akatsoulas akatsoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this works and it's efficient my concern here is that we are adding functionality to remove tags to a function that is supposed to add. Having a clear control flag to this function is confusing.

I would suggest to either break the functionality to either something like auto_tag, remove_auto_tags and break out to a helper function the common code or rename the function to something like handle_metadata_tags.

r+wc

@escattone escattone merged commit 0460c9f into mozilla:main Jun 25, 2025
2 checks passed
@escattone escattone deleted the fix-tags-2396 branch June 25, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants