6725 sorting forum posts issue #6743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escattone
reviewed
Jun 27, 2025
kitsune/questions/views.py
Outdated
Comment on lines
290
to
301
| # Handle sorting by views specially to treat NULL visit counts as 0 | ||
| if order == "views": | ||
| question_qs = question_qs.annotate( | ||
| visits_nulls_as_zero=Coalesce( | ||
| "questionvisits__visits", Value(0), output_field=IntegerField() | ||
| ) | ||
| ) | ||
| question_qs = question_qs.order_by( | ||
| "visits_nulls_as_zero" if sort == "asc" else "-visits_nulls_as_zero" | ||
| ) | ||
| else: | ||
| question_qs = question_qs.order_by(order_by if sort == "asc" else "-%s" % order_by) |
There was a problem hiding this comment.
Django provides a nice way to deal with the NULL sorting issue via the nulls_first and nulls_last keyword arguments to the asc() or desc() methods of F() instances, so you could do something like the following to cover all cases:
if sort == "asc":
order_by_expression = F(order_by).asc(nulls_first=True)
else:
order_by_expression = F(order_by).desc(nulls_last=True)
question_qs = question_qs.order_by(order_by_expression)There are several examples throughout the code that you can use as reference, for example
kitsune/kitsune/forums/views.py
Line 59 in 84d1bad
There was a problem hiding this comment.
Thanks @escattone - awesome.
akatsoulas
approved these changes
Jun 27, 2025
escattone
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nulls rise to the top of the sort order with Postgres - this corrects that issue for Questions by changing nulls to zero.