Skip to content

Quick and dirty fix for the #388 HMR issue #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 18, 2019
Merged

Quick and dirty fix for the #388 HMR issue #444

merged 5 commits into from
Mar 18, 2019

Conversation

msaelices
Copy link

See #388

@msaelices msaelices requested a review from rigor789 March 4, 2019 01:06
@msaelices msaelices mentioned this pull request Mar 4, 2019
Closed
@codecov-io
Copy link

codecov-io commented Mar 4, 2019 •
edited
Loading

Codecov Report

Merging #444 into master will decrease coverage by 0.64%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
- Coverage   13.63%   12.99%   -0.65%     
==========================================
  Files          44       45       +1     
  Lines        1210     1270      +60     
  Branches      285      294       +9     
==========================================
  Hits          165      165              
- Misses        822      876      +54     
- Partials      223      229       +6
Impacted Files Coverage Δ
platform/nativescript/renderer/ViewNode.js 96.15% <ø> (ø) ⬆️
platform/nativescript/plugins/navigator-plugin.js 0% <0%> (ø) ⬆️
...latform/nativescript/runtime/modules/transition.js 0% <0%> (ø) ⬆️
platform/nativescript/runtime/components/frame.js 0% <0%> (ø) ⬆️
platform/nativescript/runtime/components/page.js 0% <0%> (ø) ⬆️
platform/nativescript/util/hmr.js 0% <0%> (ø)
...tform/nativescript/runtime/components/list-view.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748d39a...1fa6b8b. Read the comment docs.

@msaelices msaelices changed the title Quick and dirty fix for the HMR issue Quick and dirty fix for the #388 HMR issue Mar 4, 2019
@rigor789 rigor789 merged commit 7e03aad into master Mar 18, 2019
@msaelices msaelices mentioned this pull request Apr 5, 2019
Closed
@rigor789 rigor789 deleted the hmr-fixes branch December 5, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigor789 rigor789 Awaiting requested review from rigor789

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msaelices @codecov-io @rigor789