Explicit configuration of schema extraction #374
Merged
+43
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -138,6 +138,14 @@ def test_simple_kg_pipeline_config_manual_schema() -> None: | |||
| assert isinstance(config._get_schema(), SchemaBuilder) | |||
|
|
|||
|
|
|||
| def test_simple_kg_pipeline_config_literal_schema_validation() -> None: | |||
| config = SimpleKGPipelineConfig(schema="NO_EXTRACTION") # type: ignore | |||
There was a problem hiding this comment.
looking at it here, I am wondering if "NO_EXTRACTION" is the best term to use? when putting it next to "AUTO_EXTRACTION" it makes sense but here it is a bit ambiguous? would "NO_SCHEMA" or "NO_GUIDING_SCHEMA" be better? as it does not only cover not being extracted but not provided at all? I am not strongly opinionated about it though as it is well-documented...
There was a problem hiding this comment.
Updated after private discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
schema_parameter can be configured with a string "NO_EXTRACTION" or "AUTO_EXTRACTION". Internally, this is changed to either an empty schema or None, so that the rest of the process is unchanged.Type of Change
Complexity
Complexity: Low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):