Skip to content

feature: incorporate NIC into NGINX 1 Console (not yet for NGF) #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feature: incorporate NIC into NGINX 1 Console (not yet for NGF) #736

wants to merge 19 commits into from

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Jun 24, 2025 •
edited
Loading

Proposed changes

Based on a review of internal Figma diagrams

Closes #ISSUE

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@mjang mjang self-assigned this Jun 24, 2025
@mjang mjang requested a review from a team as a code owner June 24, 2025 15:41
@mjang mjang marked this pull request as draft June 24, 2025 15:41
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one NGINX One Console labels Jun 24, 2025
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/736/

ADubhlaoich
ADubhlaoich reviewed Jun 24, 2025
View reviewed changes
@mjang mjang requested review from ADubhlaoich and AlexFenlon June 24, 2025 18:09
@mjang mjang requested a review from shaun-nx June 25, 2025 12:13
@mjang mjang marked this pull request as ready for review June 25, 2025 12:15
@mjang mjang requested a review from a team as a code owner June 25, 2025 12:15
@mjang mjang force-pushed the nic-ngf-nginx-one-integration branch from b7b25b7 to eedeb06 Compare June 25, 2025 12:21
@mjang mjang changed the title DRAFT feature: incorporate NIC and NGF into NGINX 1 Console feature: incorporate NIC and NGF into NGINX 1 Console Jun 25, 2025
mjang
mjang commented Jun 26, 2025
View reviewed changes
mjang
mjang commented Jun 26, 2025
View reviewed changes
mjang
mjang commented Jun 26, 2025
View reviewed changes
@mjang mjang force-pushed the nic-ngf-nginx-one-integration branch from 6b7c067 to 9cd9002 Compare June 27, 2025 18:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2025 •
edited
Loading

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

ADubhlaoich
ADubhlaoich approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor feedback.

@mjang mjang changed the title feature: incorporate NIC and NGF into NGINX 1 Console feature: incorporate NIC into NGINX 1 Console (not yet for NGF) Jun 30, 2025
jputrino
jputrino reviewed Jun 30, 2025
View reviewed changes
jputrino
jputrino reviewed Jun 30, 2025
View reviewed changes
jputrino
jputrino reviewed Jun 30, 2025
View reviewed changes
jputrino
jputrino reviewed Jun 30, 2025
View reviewed changes
jputrino
jputrino reviewed Jun 30, 2025
View reviewed changes
jputrino
jputrino reviewed Jun 30, 2025
View reviewed changes
jputrino
jputrino reviewed Jun 30, 2025
View reviewed changes
@mjang mjang mentioned this pull request Jun 30, 2025
Open
@mjang @jputrino
Apply suggestions from code review
3e5671c 
Co-authored-by: Jodie Putrino <jputrino@users.noreply.github.com>
travisamartin
travisamartin reviewed Jun 30, 2025
View reviewed changes
travisamartin
travisamartin reviewed Jun 30, 2025
View reviewed changes
@mjang @travisamartin
Apply suggestions from code review
334fb42 
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
sylwang
sylwang reviewed Jun 30, 2025
View reviewed changes
mjang and others added 2 commits June 30, 2025 16:58
@mjang @sylwang
Apply suggestions from code review
8c2c658 
Co-authored-by: Sylvia Wang <139922338+sylwang@users.noreply.github.com>
@mjang
Apply suggestions from code review
351a25e
sylwang
sylwang approved these changes Jul 1, 2025
View reviewed changes
ADubhlaoich and others added 2 commits July 1, 2025 14:24
@ADubhlaoich
Merge branch 'main' into nic-ngf-nginx-one-integration
71650ed
@mjang @sylwang
Apply suggestions from code review
19f7def 
Co-authored-by: Sylvia Wang <139922338+sylwang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@jputrino jputrino jputrino approved these changes

@travisamartin travisamartin travisamartin approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@sylwang sylwang sylwang approved these changes

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

Assignees

@mjang mjang

Labels
documentation Improvements or additions to documentation product/nginx-one NGINX One Console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mjang @ADubhlaoich @jputrino @travisamartin @AlexFenlon @sylwang