Skip to content

add options capability to range input, add typography to site, fix sw… #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

chillenberger
Copy link
Contributor

  • Typography for site
  • Add options to range input
  • Center text in switch input
Screenshot 2023-10-19 at 11 09 39 AM

@chillenberger chillenberger merged commit 16c87d4 into master Oct 19, 2023
@chillenberger chillenberger deleted the dan-range-input-update branch October 19, 2023 17:44
// .h6 {font-weight: 700; font-size: 24px; line-height: 30px;}
.h1-big {
font-weight: $font-weight-bold; font-size: 80px; line-height: 84px;
@include media-breakpoint-down(md) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right? I remember last time we did this, the fonts were too small on mobile, not too big.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you're also looking for "display" classes which are the headers but "big": https://getbootstrap.com/docs/5.3/content/typography/#display-headings

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On another note, I don't think we should be using pixels anymore, but rems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No before they were too big on mobile. I'll send you the slack conversation.

Copy link
Contributor Author

@chillenberger chillenberger Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly this can be redone the bootstap way (setitng the scss variables). Unfortunately some of the measurements in rem are pretty ugly fractions

Copy link
Contributor

@levkk levkk Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should adjust our typography accordingly I think. Pixels are not responsive if I remember correctly, that's why the industry switched to ems and then to rems. I could be wrong about the reasoning, but I'm pretty certain everyone uses rems these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants