Skip to content

should be ok not 400 #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2023
Merged

should be ok not 400 #1251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pgml-dashboard/src/api/cms.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ This is the end of the markdown
let rsp = req.dispatch().await;

assert!(
rsp.status() == Status::NotFound,
rsp.status() == Status::Ok,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 404 when doc not found. If we return ok, google will index the not found page and real and pollute the search index.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I can switch it back. We will have to wait on keeping the lefthand nav on bad path then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what the connection between this and the leftnav is with the current context.

Copy link
Contributor Author

@chillenberger chillenberger Dec 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a bad path Montana would like the other docs there on the left so the user can easy navigate away from the 404 response.

Screenshot 2023-12-20 at 4 00 03 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, you'll just need a custom 404 page for the docs instead of using the default one. You can set that up with a 404 catcher in rocket.

"Returned status {:?}",
rsp.status()
);
Expand Down