Rust extension - XGBoost #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montanalow
reviewed
Aug 30, 2022
pgml_rust/src/lib.rs
Outdated
| /// | ||
| /// ``` | ||
| /// SELECT * FROM pgml_train('pgml.diabetes', ARRAY['age', 'sex'], 'target'); | ||
| #[pg_extern] |
There was a problem hiding this comment.
Suggested change
| #[pg_extern] | |
| #[pg_extern] | |
| #[search_path(pgml, public)] |
There was a problem hiding this comment.
The pgml schema is not used in this one, at least not yet. I'm building this parallel to pgml in pgml_rust, so this can be used as an optimization for available algorithms.
pgml_rust/src/lib.rs
Outdated
| let features = features.iter().map(|column| format!("CAST({} AS REAL)", column)).collect::<Vec<String>>(); | ||
|
|
||
| let query = format!( | ||
| "SELECT {}, CAST({} AS REAL) FROM {} ORDER BY RANDOM()", features.clone().join(", "), label, table |
There was a problem hiding this comment.
Is this how you're getting around select * from foo?
There was a problem hiding this comment.
Yup, everything coming in is guaranteed to be a REAL so we can get is as value::<f32>()
SilasMarvin
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Rust XGBoost POC * README * vendor * cleanup * remove submodule * readme * Vendor * readme * Cleaner * version * move files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Rust XGBoost POC:
Latency per prediction varies between 0.9ms and 6ms.