Dropdown + ellipsis fix #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I run your code on my computer the left nav does not collapse correctly. What it looks like on my computer should look like |
|
Ah, this is because |
| </span> | ||
| </button> | ||
|
|
||
| <div class="menu-item horizontal-hide dropdown-toggle collapsed <% if collapsable { %> leftnav-collapse-affect <% } %>" href="#" role="button" data-bs-toggle="dropdown" data-bs-offset="68, -44" aria-expanded="false"> |
There was a problem hiding this comment.
We might want the ability to control this data-bs-offset. It controls where the dropdown menu appears relative to its default position. Also, I can see needing to position the dropdown list left center or right very useful.
levkk
force-pushed
the
levkk-dropdown-ellipsis
branch
from
51262ee to
e95e7fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropdowncomponent.