-
Notifications
You must be signed in to change notification settings - Fork 10
change result #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: result-as-tuple
Are you sure you want to change the base?
change result #148
Conversation
I also modified one thing in the code (I just did some simple research):
|
@chandr-andr ,In 8cc74de, I made further optimizations to improve performance. I only conducted simple tests with pytest, no benchmarking. Can you run some tests? If there's a performance regression, feel free to roll back the code. |
@bymoye Thank you very much for refactoring, it looks awesome. Will run them in the evening |
@bymoye I run benchmarks, I have, I found a difference, not big, but you didn't do anything worse. |
The rest of the changes look awesome, thank you a lot! |
ok!Thank you for testing |
@chandr-andr I checked your code, and I think the current test is not right. Because the engine benchmark should test the performance of the engine, not the performance of the database. So the database query should not use |
For example, a single query uses SELECT 1; |
Time Complexity: The original code has a time complexity of Optimized: Memory is allocated once and used throughout, ensuring stability and efficiency. Memory Copy: Original: Memory copy operations occur Total Copied Elements: Original: These optimizations should bring significant performance improvements to querying data values (especially for big data). |
No description provided.