gh-76535: Add C API functions for changing case of a single codepoint #117117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysnikolaou
force-pushed
the
add-unicode-casing-capi
branch
from
0a5c213 to
8facf19
Compare
Eclips4
reviewed
Mar 21, 2024
Comment on lines
+226
to
+233
| .. c:function:: int Py_UNICODE_ISCASED(Py_UCS4 ch) | ||
|
|
||
| Return ``1`` or ``0`` depending on whether *ch* is a cased character. | ||
|
|
||
| .. c:function:: int Py_UNICODE_ISCASEIGNORABLE(Py_UCS4 ch) | ||
|
|
||
| Return ``1`` or ``0`` depending on whether *ch* is a case-ignorable character. | ||
|
|
There was a problem hiding this comment.
Please add the versionadded label :)
|
Please add tests. I see a handful of flaws in the design and the implementation, the tests will expose them. |
|
Closing this in favor of #136176. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, move
iscasedandiscaseignorablefrom the internal API to the public API and add convenience macros. These are needed to handle the capital sigma case.Closes #76535.
📚 Documentation preview 📚: https://cpython-previews--117117.org.readthedocs.build/