-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-128074: Add support +HH
format as time zone in datetime.strptime
#130390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has conflicts now.
Doc/library/datetime.rst
Outdated
@@ -2609,7 +2609,7 @@ convenience. These parameters all correspond to ISO 8601 date values. | |||
| | Jan 4. | | | | |||
+-----------+--------------------------------+------------------------+-------+ | |||
| ``%:z`` | UTC offset in the form | (empty), +00:00, | \(6) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not implemented? It is not implemented in _strptime
at all in fact ... #121237
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it's better not to touch this part of documentation and change it only in PR that adds support %:z
, right?
I also suggest opening a new PR if the author doesn't respond within a couple of weeks (maybe you can add his handler in your comment to ping him:)
I made the minute (
MM
) part optional for time zone.New behavior:
Old behavior:
📚 Documentation preview 📚: https://cpython-previews--130390.org.readthedocs.build/