gh-135836: Fix IndexError in asyncio.create_connection() #135875
+64
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
serhiy-storchaka
added
needs backport to 3.13
It occurs when non-OSError exception is raised during connection and socket's close() raises OSError.
serhiy-storchaka
force-pushed
the
asyncio-create_connection-indexerror
branch
from
caa0472 to
2c7545f
Compare
| sock.close() | ||
| try: | ||
| sock.close() | ||
| except OSError: |
There was a problem hiding this comment.
I am not sure if suppressing this error is correct here.
There was a problem hiding this comment.
I think it is okay. It is an error in closing just created connection, it is less interesting than the original non-OSError error.
We do not even know what is this error, because we have no reproducer. ECONNRESET is already ignored in socket.close(). I suspect that this is similar error (maybe EINTR?) which should always be ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It occurs when non-OSError exception is raised during connection and socket's close() raises OSError.