gh-135995: Fix missing char in palmos encoding #135990
Conversation
0x8b correctly encodes to ‹, but 0x9b was mistakenly marked as a control character instead of ›.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Hello! It is very interesting to see someone using PalmOS! IIRC the last release was years ago. You need to sign the CLA to allow us to merge your pr. I'm not quite sure what to label this, I guess it could just be skip-news/issue and I'm curious as to what Benedikt will pick. |
|
Thanks for the PR! This is a user-facing change, so an issue and news entry would be appropriate. I'd recommend opening a new issue with what you wrote here -- #106326 is somewhat different. You can refer to https://devguide.python.org/getting-started/pull-request-lifecycle/ for more info |
|
I'm not Benedikt, but this looks like it needs both an issue and news entry. We probably also want a test case. |
|
Will do. |
nkorth
changed the title
Misc/NEWS.d/next/Library/2025-06-26-17-28-49.gh-issue-135995.pPrDCt.rst
Outdated
Show resolved
Hide resolved
…PrDCt.rst Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
Misc/NEWS.d/next/Library/2025-06-26-17-28-49.gh-issue-135995.pPrDCt.rst
Outdated
Show resolved
Hide resolved
…PrDCt.rst Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
|
The current encodings also maps 0x9d and 0x9e to ''. The chart shows a diagonal line an gamma-like loop, both with arrows? at the lower left. Should this be fixed also, or are these too far from any unicode chars? @ZeroIntensity I am not familiar with codec tests; what would a test look like? This is not a calculated result. |
|
I misunderstood the original issue. You're right, this isn't really testable. |
Those are both proprietary Palm OS icons which don't exist in Unicode, so I think they're fine as-is. (To elaborate, they should actually never appear in text data: both icons are temporarily displayed as input hints until another letter is entered. Kinda like a keyboard shortcut, but for handwriting input. The dot in the corner indicates where to start writing the symbol.) |
ZeroIntensity
added
needs backport to 3.13
Misc/NEWS.d/next/Library/2025-06-26-17-28-49.gh-issue-135995.pPrDCt.rst
Outdated
Show resolved
Hide resolved
|
Thanks @nkorth for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
0x8b correctly encodes to ‹, but 0x9b was mistakenly marked as a control character instead of ›. --------- (cherry picked from commit 58a42de) Co-authored-by: Nathan Korth <nkorth@users.noreply.github.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Brian Schubert <brianm.schubert@gmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-136001 is a backport of this pull request to the 3.14 branch. |
0x8b correctly encodes to ‹, but 0x9b was mistakenly marked as a control character instead of ›. --------- (cherry picked from commit 58a42de) Co-authored-by: Nathan Korth <nkorth@users.noreply.github.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Brian Schubert <brianm.schubert@gmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
GH-136002 is a backport of this pull request to the 3.13 branch. |
…36002) gh-135995: Fix missing char in palmos encoding (GH-135990) 0x8b correctly encodes to ‹, but 0x9b was mistakenly marked as a control character instead of ›. --------- (cherry picked from commit 58a42de) Co-authored-by: Nathan Korth <nkorth@users.noreply.github.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Brian Schubert <brianm.schubert@gmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
…36001) gh-135995: Fix missing char in palmos encoding (GH-135990) 0x8b correctly encodes to ‹, but 0x9b was mistakenly marked as a control character instead of ›. --------- (cherry picked from commit 58a42de) Co-authored-by: Nathan Korth <nkorth@users.noreply.github.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Brian Schubert <brianm.schubert@gmail.com> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
0x8b correctly encodes to ‹, but 0x9b was mistakenly marked as a control character instead of ›. You can see the correct glyphs in this screenshot of Palm OS 3.5, or on this page: