Skip to content

gh-136047: Allow typing._allow_reckless_class_checks to check _py_abc #136115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-136047: Allow typing._allow_reckless_class_checks to check _py_abc #136115

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4735de5
gh-136047 Allow typing._allow_reckless_class_checks to check `_py_abc`
youknowone Jun 30, 2025
8e21694
Revert "gh-136047 Allow typing._allow_reckless_class_checks to check …
youknowone Jun 30, 2025
519898d
Simply add _py_abc
youknowone Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1860,7 +1860,9 @@ def _allow_reckless_class_checks(depth=2):
The abc and functools modules indiscriminately call isinstance() and
issubclass() on the whole MRO of a user class, which may contain protocols.
"""
return _caller(depth) in {'abc', 'functools', None}
# gh-136047: When `_abc` module is not available, `_py_abc` is required to
# allow `_py_abc.ABCMeta` fallback.
return _caller(depth) in {'abc', '_py_abc', 'functools', None}


_PROTO_ALLOWLIST = {
Expand Down
Loading