gh-136183: Deal with escapes in JIT optimizer's constant evaluator #136184
+75
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skip news because no version of JIT has released with this yet. |
Fidget-Spinner
changed the title
Fidget-Spinner
requested review from
brandtbucher and
savannahostrowski
as code owners
brandtbucher
approved these changes
Jul 1, 2025
| @@ -5,6 +5,7 @@ on: | |||
| - '**jit**' | |||
| - 'Python/bytecodes.c' | |||
| - 'Python/optimizer*.c' | |||
| - 'Python/executor_cases.c.h' | |||
There was a problem hiding this comment.
Should we add optimizer_cases.c.h too?
| self.assertIsNotNone(ex) | ||
| uops = get_opnames(ex) | ||
|
|
||
| # For now.. until we constant propagte it away. |
There was a problem hiding this comment.
Suggested change
| # For now.. until we constant propagte it away. | |
| # For now... until we constant propagate it away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_BINARY_OPevaluation produces UB (and incorrect results) #136183