Skip to content

contrib: restructure Getting Started - Setup and Building into a Workflows section #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 23, 2025

Conversation

nedbat
Copy link
Member

@nedbat nedbat commented Nov 4, 2024

The Getting Started section has a lot of technical detail. I thought it
would be better moved to the end, and referenced from the contribution
paths earlier in the guide. I haven't updated the paths yet.

Also:

  • I added a central links.rst that can be included anywhere.
  • I omitted the "Editors and tools" section. It doesn't provide any useful information.
  • Perhaps the Workflows section could be further categorized.
  • The c_blah_start and c_blah_end comments are only for the temporary inclusions being used to demonstrate the new organization.

📚 Documentation preview 📚: https://cpython-devguide--1467.org.readthedocs.build/

This makes it easier to move content around without worrying about where
the links are defined.  It will also be easier to have canonical links
that can be used from multiple places in the guide.
…flows section

The Getting Started section has a lot of technical detail.  I thought it
would be better moved to the end, and referenced from the contribution
paths earlier in the guide.  I haven't updated the paths yet.

Also:

- I added a central links.rst that can be included anywhere.
- I omitted the "Editors and tools" section. It doesn't provide any useful information.
- Perhaps the Workflows section could be further categorized.
- The `c_blah_start` and `c_blah_end` comments are only for the temporary inclusions being used to demonstrate the new organization.
@nedbat nedbat requested review from hugovk and willingc November 4, 2024 14:52
@willingc
Copy link
Collaborator

willingc commented Nov 4, 2024

@nedbat I did a quick scan and looked good. I'm traveling tomorrow so can look more closely then.

@nedbat nedbat marked this pull request as ready for review November 11, 2024 22:55
@nedbat nedbat marked this pull request as draft November 11, 2024 22:58
@nedbat nedbat marked this pull request as ready for review March 20, 2025 18:52
@nedbat
Copy link
Member Author

nedbat commented Mar 20, 2025

It's been a while since I made this. I want to merge it and iterate.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only skimmed it, but go for it!

@nedbat nedbat merged commit 6ea7bd6 into python:main Mar 23, 2025
4 checks passed
@nedbat nedbat deleted the nedbat/workflows branch March 23, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants