Metaclass conflict check improvements #17682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The tests passed locally. I'm not quite sure what's going on. I'll dig deeper when I'm back from vacation in about a week. |
This comment has been minimized.
This comment has been minimized.
robsdedude
force-pushed
the
metaclass-conflict-check-improvements
branch
from
3cab486 to
6b0f4c3
Compare
This comment has been minimized.
This comment has been minimized.
robsdedude
force-pushed
the
metaclass-conflict-check-improvements
branch
from
6b0f4c3 to
27e9da3
Compare
This comment has been minimized.
This comment has been minimized.
robsdedude
commented
Jun 30, 2025
mypy/checker.py
Outdated
| self.fail( | ||
| "Metaclass conflict: the metaclass of a derived class must be " | ||
| "a (non-strict) subclass of the metaclasses of all its bases", | ||
| f"a (non-strict) subclass of the metaclasses of all its bases{explanation}", |
There was a problem hiding this comment.
I'm aware that adding the explanation makes error message differ from the runtime error. However, since type hints sometimes don't follow the actual runtime metaclasses (s. issue this PR is supposed fix), I think this information can be valuable.
There was a problem hiding this comment.
Mypy errors don't necessarily have to mirror runtime errors exactly. It's nice to be consistent, but maybe we have more information so we can give a more detailed error, or we think a different wording is more informative.
|
@hauntsaninja You offered to have a look, thanks again. The PR is ready for review. |
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: artigraph (https://github.com/artigraph/artigraph)
- src/arti/versions/__init__.py:17: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/versions/__init__.py:17: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/versions/__init__.py:17: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/statistics/__init__.py:8: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/statistics/__init__.py:8: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/statistics/__init__.py:8: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/annotations/__init__.py:8: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/annotations/__init__.py:8: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/annotations/__init__.py:8: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/types/__init__.py:26: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/types/__init__.py:26: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/types/__init__.py:26: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/types/__init__.py:44: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/types/__init__.py:44: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/types/__init__.py:44: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/types/__init__.py:48: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/types/__init__.py:48: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/types/__init__.py:48: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/types/__init__.py:61: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/types/__init__.py:61: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/types/__init__.py:61: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/types/__init__.py:347: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/types/__init__.py:347: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/types/__init__.py:347: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/thresholds/__init__.py:11: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/thresholds/__init__.py:11: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/thresholds/__init__.py:11: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/partitions/__init__.py:21: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/partitions/__init__.py:21: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/partitions/__init__.py:21: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/formats/__init__.py:11: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/formats/__init__.py:11: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/formats/__init__.py:11: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/storage/__init__.py:24: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/storage/__init__.py:24: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/storage/__init__.py:24: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/storage/__init__.py:45: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/storage/__init__.py:45: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/storage/__init__.py:45: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/storage/__init__.py:65: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/storage/__init__.py:65: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/storage/__init__.py:65: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/artifacts/__init__.py:24: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/artifacts/__init__.py:24: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/artifacts/__init__.py:24: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/views/__init__.py:20: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/views/__init__.py:20: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/views/__init__.py:20: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/backends/__init__.py:133: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/backends/__init__.py:133: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/backends/__init__.py:133: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/producers/__init__.py:56: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/producers/__init__.py:56: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/producers/__init__.py:56: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/producers/__init__.py:464: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/producers/__init__.py:464: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/producers/__init__.py:464: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/graphs/__init__.py:94: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/graphs/__init__.py:94: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/graphs/__init__.py:94: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/graphs/__init__.py:294: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/graphs/__init__.py:294: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/graphs/__init__.py:294: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/executors/__init__.py:17: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/executors/__init__.py:17: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/executors/__init__.py:17: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- src/arti/storage/google/cloud/storage.py:18: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ src/arti/storage/google/cloud/storage.py:18: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ src/arti/storage/google/cloud/storage.py:18: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- tests/arti/internal/test_models.py:13: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ tests/arti/internal/test_models.py:13: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ tests/arti/internal/test_models.py:13: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- tests/arti/internal/test_models.py:17: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ tests/arti/internal/test_models.py:17: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ tests/arti/internal/test_models.py:17: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- tests/arti/internal/test_models.py:43: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ tests/arti/internal/test_models.py:43: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ tests/arti/internal/test_models.py:43: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- tests/arti/internal/test_models.py:54: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ tests/arti/internal/test_models.py:54: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ tests/arti/internal/test_models.py:54: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- tests/arti/internal/test_models.py:84: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ tests/arti/internal/test_models.py:84: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ tests/arti/internal/test_models.py:84: note: "arti.internal.models.ModelMeta" (metaclass of "arti.internal.models.Model") conflicts with "pydantic._internal._model_construction.ModelMetaclass" (metaclass of "pydantic.main.BaseModel")
- tests/arti/internal/test_models.py:108: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
... (truncated 2 lines) ...
comtypes (https://github.com/enthought/comtypes)
- comtypes/_post_coinit/unknwn.py:266: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [misc]
+ comtypes/_post_coinit/unknwn.py:266: error: Metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases [metaclass]
+ comtypes/_post_coinit/unknwn.py:266: note: "comtypes._post_coinit.unknwn._compointer_meta" (metaclass of "comtypes._post_coinit.unknwn._compointer_base") conflicts with "_ctypes._PyCSimpleType" (metaclass of "_ctypes._SimpleCData")
steam.py (https://github.com/Gobot1234/steam.py)
- steam/utils.py:458: error: Dynamic metaclass not supported for "StructIO" [misc]
+ steam/utils.py:458: error: Dynamic metaclass not supported for "StructIO" [metaclass]
|
hauntsaninja
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some points of #14033:
metaclass).I didn't attempt to fix that mypy follows the logic for determining the metaclass as documented whereas it should follow what the interpreter is actually doing (#14033 (comment)). I think such a change is better kept as a separate PR, which is why I don't want to close the issue with this PR.
EDIT: (Now that #17713 is merged)
Fixes: #14033