PEP 788: Minor editorial fixes #4477
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
approved these changes
Jul 1, 2025
peps/pep-0788.rst
Outdated
Comment on lines
665
to
666
| There are two ``PyGILState`` APIs that act as an abstraction for | ||
| :term:`thread states <thread state>`. For some background, Python stores |
There was a problem hiding this comment.
What I mean by “porting guide” is concrete steps to do when the compiler gives you deprecation warnings. No background and theory, and as few assumptions as possible about the reader knowing what the code in question does (i.e. if there's a purely mechanical replacement, write that; otherwise list alternatives and say how to choose between them; and say what to watch out for.)
Here's one I wrote recently: https://peps.python.org/pep-0793/#porting-guide
(A porting guide doesn't need to be in the PEP, but it should be in the final docs. Might be best to remove it from this PR.)
There was a problem hiding this comment.
Ok, let's remove it for now. We can circle back to it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 123: Summary of changes)Addresses Petr's editorial comments, apart from the PEP title. I'm not sure it's a good idea to change the title at this point.
📚 Documentation preview 📚: https://pep-previews--4477.org.readthedocs.build/pep-0788/