Bump pyflakes to 3.4.* #14316
Merged
Bump pyflakes to 3.4.* #14316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Akuli
reviewed
Jun 30, 2025
Comment on lines
+316
to
+317
| def TEMPLATESTR(self, node: _TemplateStr) -> None: ... | ||
| def INTERPOLATION(self, tree: _Interpolation, omit: _OmitType = None) -> None: ... |
There was a problem hiding this comment.
Instead of type aliases, would it be better to put the if statements directly here, like this?
Suggested change
| def TEMPLATESTR(self, node: _TemplateStr) -> None: ... | |
| def INTERPOLATION(self, tree: _Interpolation, omit: _OmitType = None) -> None: ... | |
| if sys.version_info >= (3, 14): | |
| def TEMPLATESTR(self, node: ast.TemplateStr) -> None: ... | |
| def INTERPOLATION(self, tree: ast.Interpolation, omit: _OmitType = None) -> None: ... | |
| else: | |
| # The methods using these should never be called on Python < 3.14. | |
| def TEMPLATESTR(self, node: Never) -> None: ... | |
| def INTERPOLATION(self, tree: Never, omit: _OmitType = None) -> None: ... |
This way IDE users will see ast.TemplateStr instead of _TemplateStr in hover tooltips and such. Type checker error messages will also be better.
The downside is that overriding the method is more difficult, but to me it seems like it's not meant to be overwritten.
There was a problem hiding this comment.
good idea, but the practice of using type aliases has developed before
we can suggest doing this in a separate PR/issue for the entire file (I think this would be more correct)
Akuli
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #14314