Skip to content

Some improvements to our tox environment defaults #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2022
Merged

Some improvements to our tox environment defaults #2019

merged 2 commits into from
May 10, 2022

Conversation

JohnVillalovos
Copy link
Member

  • Rename pep8 environment to flake8
  • Run the pylint test by default

@JohnVillalovos JohnVillalovos requested a review from nejch May 10, 2022 15:42
Previously the test was called `pep8`. The test only runs `flake8` so
call it `flake8` to be more precise.
Since we require `pylint` to pass in the CI. Let's run it by default
in tox.
@JohnVillalovos JohnVillalovos changed the title Some improvements to our tox environment running Some improvements to our tox environment defaults May 10, 2022
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, totally missed we haven't been running that one env by default:)

@nejch nejch merged commit d121d2d into main May 10, 2022
@nejch nejch deleted the jlvillal/tox branch May 10, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants