Skip to content

Be more forgiving when assigning UDT scalar to everything #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2022
Merged

Be more forgiving when assigning UDT scalar to everything #299

merged 1 commit into from
Oct 26, 2022

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented Oct 22, 2022

This allows e.g A << (1, 2, 3) to assign a scalar to every value. Before, we required A[:, :] = (1, 2, 3).

I don't think there was any reason I didn't do this before other than I overlooked it.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 98.668% when pulling a3be6d3 on eriknw:flexible_udt_assign_scalar into d0c41f2 on python-graphblas:main.

@eriknw eriknw requested a review from jim22k October 22, 2022 03:50
@eriknw eriknw added the enhancement Improve existing functionality or make things work better label Oct 22, 2022
@eriknw eriknw merged commit 5852ff3 into python-graphblas:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim22k jim22k Awaiting requested review from jim22k

Assignees
No one assigned
Labels
enhancement Improve existing functionality or make things work better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eriknw @coveralls