-
Notifications
You must be signed in to change notification settings - Fork 126
Merge pyldap + python-ldap #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andatory for python-ldap 2.5.0+
…rom new sub-module ldap.pkginfo also to setup.py
…d pyasn1_modules 0.1.5+
… must match _ldap.__version__
VLVResponseControl.decodeControlValue() now follow the coding convention to use camel-cased ASN.1 name as class attribute name. The old class names are still set for back-ward compability but should not be used in new code because they might be removed in a later release. * removed SSSRequestControl from ldap.controls.KNOWN_RESPONSE_CONTROLS
Note that for backwards compatibility, cidict keeps the has_key method even on Python 3.
The symlink is intended for tools that automatically pretty-print the file.
This should eventually be moved elsewhere in the docs.
- DNs, attribute names, URLs are text (encoded to UTF-8 on the wire) - Attribute values are always bytes A "bytes_mode" switch controls behavior under Python 2.
- Add 3.3 - 3.6 to tox.ini - Add .travis.yml for Travis CI - Add 3.3 - 3.6 to Trove classifiers - Add Python version checking to setup.py
The changes are squashed, so we don't have line-by-line authorship in Git. List people here instead, and link to the history.
The full history of the pyldap fork can be found at https://github.com/pyldap/pyldap/
cc @tiran |
Confirmed, only
|
Known issue: README formatting is wrong, but let's fix it up after committing this. |
tox tests are passing on my machine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges Michael's 2.5.x branch from CVS, and the pyldap project.
The result should be the same as in pyldap/pyldap#142, except there's no deprecation note in the README.
edit: And the CHANGELOG is different