Skip to content

Switch _ParseMode to int as it can accept combined modes #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Spitfire1900
Copy link
Contributor

_ParseMode accepts multiple modes at the same time, but parse_mode=rapidjson.PM_TRAILING_COMMAS | rapidjson.PM_COMMENTS causes type checker errors.

@lelit
Copy link
Contributor

lelit commented Jun 26, 2024

I'd say the same should be applied (at least) to _DatetimeMode, _MappingMode and _NumberMode too?

@lelit lelit merged commit 212ea75 into python-rapidjson:master Jun 29, 2024
8 of 9 checks passed
@Spitfire1900 Spitfire1900 deleted the _parsemode-can-combine-modes branch July 2, 2024 03:18
Spitfire1900 added a commit to Spitfire1900/python-rapidjson that referenced this pull request Jan 2, 2025
This reverts commit 212ea75, reversing
changes made to 3d84f0a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants