fix: enable --print-last-released* when in detached head or non-release branch
#926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codejedi365
force-pushed
the
fix/branch-restriction-enforcement
branch
5 times, most recently
from
e08c104 to
93f04e7
Compare
codejedi365
force-pushed
the
fix/branch-restriction-enforcement
branch
2 times, most recently
from
42a7cfc to
9111990
Compare
codejedi365
changed the title
--print when in detached head or non-release branch--print-last-released* when in detached head or non-release branch
codejedi365
force-pushed
the
fix/branch-restriction-enforcement
branch
from
9111990 to
d8e7851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
version --print-last-releasedoutside of release branches #900Rationale
When using PSR to evaluate what the last released tag was, it is irrelevant to impose release branch restrictions on the usage as it doesn't matter what branch you are actually on.
--printand--print-tagare not included here as those determine the next version value and those do currently rely upon the release branch configuration.How I tested
Created test cases that evaluate non-release branch environments in regular or strict mode while using
--print-last-released,--print-last-released-tag. The tests also evaluated the same command when in a detached head state.