Skip to content

Remove Python 3.7 workaround for PicklePersistence #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 9, 2023

Conversation

harshil21
Copy link
Member

Closes #3732

I don't think anything in tests need to change?

@harshil21 harshil21 added 🛠 refactor change type: refactor 🔗 python related technology: python labels Jun 3, 2023
@harshil21 harshil21 added this to the v20.4 milestone Jun 3, 2023
@harshil21 harshil21 linked an issue Jun 4, 2023 that may be closed by this pull request
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the tests don't have explicit cases for py 3.7, right. Howover, I am wondering if it is possible to pickle data in 3.7 and unpickle it in 3.8 🤔 Could you check?

Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍 Did you have any chance to test if py37-pickled files can be loaded in py38?

@Bibo-Joshi Bibo-Joshi merged commit 9d3345c into drop-py-37 Jun 9, 2023
@Bibo-Joshi Bibo-Joshi deleted the pp-workaround branch June 9, 2023 16:10
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔗 python related technology: python 🛠 refactor change type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt Py3.8+ features: Drop workaround in PicklePersistence
2 participants