Skip to content

Fixed all H2 headings #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Fixed all H2 headings #943

merged 1 commit into from
Dec 5, 2018

Conversation

mpoulin
Copy link
Contributor

@mpoulin mpoulin commented Dec 4, 2018

Before, H2 formatting was not consistent.
Now, all H2 headings use over/under asterisks.

Before, H2 fomratting was not consistent.
Now, all H2 headings use over/under asterisks.
@dbader
Copy link
Member

dbader commented Dec 4, 2018

@mpoulin Thanks so much Marc, this is great! Hurray for consistency 😄

@return42
Copy link

return42 commented Dec 5, 2018

Sorry for nitpicking; If we change so many headings why not all and using recommended style for sections and subsections

@mpoulin
Copy link
Contributor Author

mpoulin commented Dec 5, 2018

@return42 Thanks for your comment.
Yes, the goal is to change all the headings to the recommended Sphinx style.

A prior commit fixed the H1 headings:
693c8ca

This commit fixes the H2 headings and the next commit will fix the H3 headings.
Since these are global changes and touch so many files, I thought it best to make the changes in phases.

@return42
Copy link

return42 commented Dec 5, 2018

@mpoulin thanks for clarifying .

@mpoulin mpoulin merged commit cafe323 into master Dec 5, 2018
@mpoulin mpoulin deleted the fix-h2-headers branch December 5, 2018 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants