Fix fontWeight binding (make it an abstract type) #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoOx
reviewed
Oct 18, 2022
There was a problem hiding this comment.
Nice. Sorry, I didn't had time to look for ideas as my life is a mess ATM :)
I guess we don't have much choice until syntax allow this.
Just thinking what user will have to do...
Previously style(~fontWeight=#_100, ()) & now style(~fontWeight=FontWeight._100, ()), that's correct ?
Since there is not a lot of value, why not just putting those directly at the root of Style module ?
If opened, this means people can do style(~fontWeight=_100, ()).
|
Yes, that's correct. I am not in favor of putting things directly into
|
MoOx
approved these changes
Oct 20, 2022
|
Not a fan (too verbose for me), but I guess you are right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #775