Get transcoding to work across ractors by locking certain operations #13601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-gruber
force-pushed
the
ractor_transcode_lock
branch
from
1f4242d to
1755423
Compare
This comment has been minimized.
This comment has been minimized.
luke-gruber
force-pushed
the
ractor_transcode_lock
branch
4 times, most recently
from
bfdaa5f to
f7e5bce
Compare
|
@jhawthorn Ready for review 😅 |
luke-gruber
force-pushed
the
ractor_transcode_lock
branch
from
f7e5bce to
6d1204a
Compare
Ex: `str.encode` and `str.encode!` work across ractors now. The global table `transcoder_table` needs a lock around each st_lookup/st_insert, and it's a two-level table so the second level also needs to be locked around insertion/deletion. In addition to this, the transcoder entries (values in the second-level hash table) need to be locked around retrieving them and loading them as they are loaded lazily. The transcoding objects (`Encoding::Converter`) can't be made shareable, so their operations don't need to be locked.
luke-gruber
force-pushed
the
ractor_transcode_lock
branch
from
6d1204a to
725a02d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ex:
str.encodeandstr.encode!work across ractors now.The global table
transcoder_tableneeds a lock around each st_lookup/st_insert, and it's a two-leveltable so the second level also needs to be locked around insertion/deletion. In addition to this, the
transcoder entries (values in the second-level hash table) need to be locked around retrieving them and
loading them as they are loaded lazily.
The transcoding objects (
Encoding::Converter) can't be made shareable, so their operations don't need to be locked.