Avoid deprecated dsa for tests keys #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @traylenator! I appreciate the update to the test. Can you please amend your commit message to be a conventional commit message? This will make sure this change shows up in our release notes via our automation. Something like: |
|
If you'd rather amend your commit, let me know and I can make the change myself. |
``` ssh-keygen -t dsa unknown key type dsa ``` with OpenSSH_9.9p1
|
I figured out I was able to amend the commit myself and push the update. Thank you for this contribution! |
jcouball
approved these changes
Jul 5, 2025
There was a problem hiding this comment.
💯 This change is a welcome improvement! Thanks @traylenator.
|
Thanks - am on a computer break now so would have been a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running tests on a very modern system results in
with OpenSSH_9.9p1