Drop support for Scala 2.13.{0-2}. #5102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
commented
Jan 5, 2025
compiler/src/test/scala/org/scalajs/nscplugin/test/DiverseErrorsTest.scala
Show resolved
Hide resolved
|
Yes, that sounds reasonable. It would be nice to get #5077 in, but I don't even have an ETA on that one. (it's still in the "I'm fiddling with it to figure out what needs to be done" stage). |
gzm0
approved these changes
Jan 5, 2025
| !scalaVersion.startsWith("2.12.") && | ||
| scalaVersion != "2.13.0" && | ||
| scalaVersion != "2.13.1" | ||
| !scalaVersion.startsWith("2.12.") | ||
| } |
There was a problem hiding this comment.
Maybe at this point it makes more sense to:
private val isScala212 = scalaVersion.startsWith("2.12.")
val scalaSupportsNoWarn = !isScala212(and maybe even remove usesColonInMethodSig and just use isScala212).
These were the 2.13.x versions for which we still had some custom code paths, workarounds or exceptions lying around. This commit is a followup to edc13a8.
sjrd
force-pushed
the
drop-scala-2.13.2-and-below
branch
from
4f90ff5 to
68b1c71
Compare
gzm0
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were the 2.13.x versions for which we still had some custom code paths, workarounds or exceptions lying around.
This commit is a followup to edc13a8.