Optimizer: Fail if we cannot inline RuntimeLong #5188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand how the title of the first commit relates to its changes. It looks like the changes are nothing but a refactoring, or possibly taking a shortcut in the optimizer internals. Could you elaborate? |
gzm0
changed the title
|
Ah, ah. I was under the expression that it is actually possible for the expansion to hit the "not-inline" case. It seems this doesn't happen (and I guess shouldn't happen). I have adjusted this PR to also throw an assertion error and squashed the commit. PTAL. |
If we cannot inline RuntimeLong (the class or its static methods), something is broken and we should fail.
sjrd
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we cannot inline RuntimeLong (the class or its static methods),
something is broken and we should fail.
Extracted and adapted from #5077.