Branchless algorithm for RuntimeLong.toDouble. #5204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out the computation we did in the non-negative case also works for the negative case. The proof relies on elementary properties of the two's complement representation.
I don't know how I never saw this before. To make things worse, it seems that Kotlin and J2CL knew all along, and I never realized when skimming their implementations either.
As a second commit, we introduce code paths for signed safe doubles, now that the conversions from signed longs to doubles is the same as the unsigned ones.