Skip to content

BLD fix missing license file #31594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 30, 2025
Merged

Conversation

adrinjalali
Copy link
Member

Fixes #31590

Copy link

github-actions bot commented Jun 19, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 087490c. Link to the linter CI: here

@adrinjalali adrinjalali marked this pull request as ready for review June 23, 2025 12:27
@adrinjalali
Copy link
Member Author

adrinjalali commented Jun 23, 2025

@lesteve @glemaitre while we're on the CI, I see such errors:

   E           DeprecationWarning: scipy.optimize: The `disp` and `iprint` options of the L-BFGS-B solver are deprecated and will be removed in SciPy 1.18.0.

have we seen this before?

This PR seems to be fixing the license issue, so potentially could be merged.

@lesteve
Copy link
Member

lesteve commented Jun 23, 2025

This is a scipy deprecation warning for scipy 1.6 which was recently released scipy/scipy#23197, looks like this is hitting us without prior warning in scipy-dev ...

@lesteve
Copy link
Member

lesteve commented Jun 24, 2025

I opened #31642 to tackle the iprint deprecation in scipy.

@lesteve
Copy link
Member

lesteve commented Jun 24, 2025

So I guess the summary of the fix is that the license file is in a slightly different path in the wheel archive?

This likely happened because we tweaked our pyproject.toml in #31560 (using project.license-files rather than project.license)?

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the branch with main where the previous deprecation issue was worked around. Looks good now. Thanks

@jeremiedbb jeremiedbb merged commit dedcf1f into scikit-learn:main Jun 30, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⚠️ CI failed on Wheel builder (last failure: Jun 30, 2025) ⚠️
3 participants