-
-
Notifications
You must be signed in to change notification settings - Fork 26k
BLD fix missing license file #31594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD fix missing license file #31594
Conversation
@lesteve @glemaitre while we're on the CI, I see such errors: E DeprecationWarning: scipy.optimize: The `disp` and `iprint` options of the L-BFGS-B solver are deprecated and will be removed in SciPy 1.18.0. have we seen this before? This PR seems to be fixing the license issue, so potentially could be merged. |
This is a scipy deprecation warning for scipy 1.6 which was recently released scipy/scipy#23197, looks like this is hitting us without prior warning in scipy-dev ... |
I opened #31642 to tackle the |
So I guess the summary of the fix is that the license file is in a slightly different path in the wheel archive? This likely happened because we tweaked our |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the branch with main where the previous deprecation issue was worked around. Looks good now. Thanks
Fixes #31590