[MRG] ENH: add plot_f1_baseline option to PrecisionRecallDisplay.plot #31600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvMossan
force-pushed
the
feat/pr-hyperbolic-baseline
branch
from
ba04696 to
44dbb5b
Compare
EvMossan
changed the title
|
Hi @scikit-learn/core-devs – friendly ping on this PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #30352
What does this implement/fix? Explain your changes.
plot_f1_baseline(default:False) to:meth:
~sklearn.metrics.PrecisionRecallDisplay.plot, which draws thehyperbolic F₁-score baseline (Flach & Kull 2015) for the “always-positive”
classifier.
f1_baseline_kwargument..plotdocstring (with.. versionadded:: 1.8) was updated so thatthis parameter appears in the HTML API reference.
sklearn/metrics/_plot/tests/test_precision_recall_display.pyto verifythat custom style kwargs (e.g.
linestyle) are actually applied.Any other comments?
All existing tests pass and the new smoke-test covers the styling branch.