✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: b1527b7. Link to the linter CI: here}

Did we or github change something? I can’t merge as long as CI is not green.

The CI failure is being tracked in #31624. @lesteve is already investigating it.

The point is that I should be able to merge even with failing CI (at least in the past that was possible).

The point is that I should be able to merge even with failing CI (at least in the past that was possible).

Required checks have been added some time ago (edit: December 2022) to enable auto-merge feature. If one of the required checks fail you can not merge. For more details see #25069. @lorentzenchr you even gave me a maintainability award about it in #25069 (comment) 😉.

Unfortunately right now we are in a very atypical and rare situation where CI is broken for every PRs (Windows is timing out on all PRs for some not fully understood reason but that seems link with MKL on a particular AMD CPU 😓) but there is hope to have a work-around soonish to get back to normal in #31641.

Thanks @lesteve for the explanation. I had the impression (also the experience?) that it was possible to manually merge with CI failures, just not auto-merge.
Let's wait for the fixes - and maybe revive the maintainability award 😏

The mechanism is the same for a human or auto-merge, if a required check is not passing, the PR can not be merged.

I double-checked, the required checks for main are listed in https://github.com/scikit-learn/scikit-learn/settings/branch_protection_rules/23621449 and right now there is only Azure and the changelog check.

I am pretty sure we used to have CircleCI but maybe we removed it at one point and forgot to add it back (vaguely rings a bell because there was a temporary CircleCI issue?). We should also add the linux arm64 tests that run on GHA ...

Here was the setting when it was originally set up #25069 (comment).